toku-mac commented on code in PR #3544:
URL: https://github.com/apache/nuttx-apps/pull/3544#discussion_r3436261317
##########
examples/rust/hello/src/lib.rs:
##########
@@ -50,7 +51,11 @@ pub extern "C" fn hello_rust_cargo_main() {
println!("Hello world from tokio!");
});
+ #[cfg(not(feature = "sim"))]
loop {
Review Comment:
I speculated that the author of examples/rust/hello may have intentionally
included an infinite loop when targeting embedded systems. If this
functionality is not actually needed, I would like to remove the loop for all
targets.
In any case, we should probably correct the signature of
`hello_rust_cargo_main()`, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
