xiaoxiang781216 commented on code in PR #19162: URL: https://github.com/apache/nuttx/pull/19162#discussion_r3443544535
########## fs/inode/fs_inode.c: ########## @@ -204,27 +231,13 @@ void inode_runlock(void) int inode_checkperm(FAR struct inode *inode, int oflags) Review Comment: ```suggestion int inode_checkopenperm(FAR struct inode *inode, int oflags) ``` ########## fs/inode/fs_inode.c: ########## @@ -276,7 +290,7 @@ int inode_checkperm(FAR struct inode *inode, int oflags) int inode_checkdirperm(FAR struct inode *dir, int amode) Review Comment: should we move all check from inode_checkperm to inode_checkperm ########## fs/inode/fs_inode.c: ########## @@ -276,7 +290,7 @@ int inode_checkperm(FAR struct inode *inode, int oflags) int inode_checkdirperm(FAR struct inode *dir, int amode) Review Comment: ```suggestion int inode_checkperm(FAR struct inode *dir, int amode) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
