Abhishekmishra2808 commented on code in PR #19166: URL: https://github.com/apache/nuttx/pull/19166#discussion_r3446822462
########## fs/littlefs/lfs_vfs.c: ########## @@ -28,12 +28,15 @@ #include <errno.h> #include <fcntl.h> -#include <stdio.h> #include <string.h> +#include <sys/stat.h> +#include <unistd.h> #include <nuttx/crc16.h> #include <nuttx/fs/fs.h> #include <nuttx/fs/ioctl.h> + +#include "inode/inode.h" Review Comment: Done. Removed the duplicate include. ########## fs/inode/inode.h: ########## @@ -455,6 +455,12 @@ int inode_checkperm(FAR struct inode *inode, int oflags); int inode_checkdirperm(FAR struct inode *dir, int amode); +#if defined(CONFIG_FS_PERMISSION) Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
