FelipeMdeO commented on code in PR #3532:
URL: https://github.com/apache/nuttx-apps/pull/3532#discussion_r3448508978
##########
netutils/dropbear/patch/0008-fix-strict-prototypes-warnings.patch:
##########
@@ -0,0 +1,76 @@
+--- a/src/common-kex.c
++++ b/src/common-kex.c
+@@ -117,7 +117,7 @@ void send_msg_kexinit() {
+
+ }
+
+-static void switch_keys() {
++static void switch_keys(void) {
+ TRACE2(("enter switch_keys"))
+ if (!(ses.kexstate.sentkexinit && ses.kexstate.recvkexinit)) {
+ dropbear_exit("Unexpected newkeys message");
+--- a/src/common-session.c
++++ b/src/common-session.c
+@@ -503,7 +503,7 @@ void ignore_recv_response() {
+ TRACE(("Ignored msg_request_response"))
+ }
+
+-static void send_msg_keepalive() {
++static void send_msg_keepalive(void) {
+ time_t old_time_idle = ses.last_packet_time_idle;
+ struct Channel *chan = get_any_ready_channel();
+
+--- a/src/dbrandom.c
++++ b/src/dbrandom.c
+@@ -129,7 +129,7 @@ static void addrandom(const unsigned char * buf, unsigned
int len) {
+ sha256_done(&hs, hashpool);
+ }
+
+-static void write_urandom()
++static void write_urandom(void)
+ {
+ #if DROPBEAR_FUZZ
+ if (fuzz.fuzzing) {
+--- a/src/packet.c
++++ b/src/packet.c
+@@ -475,7 +475,7 @@ int packet_is_okay_for_queues(unsigned char type) {
+ return 1;
+ }
+
+-static void enqueue_reply_packet() {
++static void enqueue_reply_packet(void) {
+ struct packetlist * new_item = NULL;
+ new_item = m_malloc(sizeof(struct packetlist));
+ new_item->next = NULL;
+--- a/src/svr-kex.c
++++ b/src/svr-kex.c
+@@ -114,7 +114,7 @@
+
+ #if DROPBEAR_DELAY_HOSTKEY
+
+-static void svr_ensure_hostkey() {
++static void svr_ensure_hostkey(void) {
+
+ const char* fn = NULL;
+ char *expand_fn = NULL;
+--- a/src/svr-runopts.c
++++ b/src/svr-runopts.c
+@@ -38,7 +38,7 @@ svr_runopts svr_opts; /* GLOBAL */
+ static void printhelp(const char * progname);
+ static void addportandaddress(const char* spec);
+ static void loadhostkey(const char *keyfile, int fatal_duplicate);
+ static void addhostkey(const char *keyfile);
+-static void load_banner();
++static void load_banner(void);
Review Comment:
This change is already done in dropbear mainline:
https://github.com/mkj/dropbear/pull/447
Next review corrections round will use the last dropbear version and solve
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
