This is an automated email from the ASF dual-hosted git repository.
xiaoxiang781216 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 9a4114a9d3e 1wire: Move onewire_valid_rom to 1wire_crc.h
9a4114a9d3e is described below
commit 9a4114a9d3e06e47cab2c15e00b2b29c17c10b10
Author: Jiri Vlasak <[email protected]>
AuthorDate: Thu Jun 25 14:42:31 2026 +0200
1wire: Move onewire_valid_rom to 1wire_crc.h
To let developers use all procedures implemented in the corresponding
.c file when 1wire_crc.h is included.
Signed-off-by: Jiri Vlasak <[email protected]>
---
drivers/1wire/1wire.c | 1 +
drivers/1wire/1wire_internal.h | 4 ----
include/nuttx/1wire/1wire_crc.h | 16 ++++++++++++++++
3 files changed, 17 insertions(+), 4 deletions(-)
diff --git a/drivers/1wire/1wire.c b/drivers/1wire/1wire.c
index bf6c620c825..8357413b7d3 100644
--- a/drivers/1wire/1wire.c
+++ b/drivers/1wire/1wire.c
@@ -35,6 +35,7 @@
#include <nuttx/kmalloc.h>
#include <nuttx/1wire/1wire_master.h>
#include <nuttx/1wire/1wire.h>
+#include <nuttx/1wire/1wire_crc.h>
#include "1wire_internal.h"
diff --git a/drivers/1wire/1wire_internal.h b/drivers/1wire/1wire_internal.h
index 867d1d3f6cf..0e6c48227be 100644
--- a/drivers/1wire/1wire_internal.h
+++ b/drivers/1wire/1wire_internal.h
@@ -66,10 +66,6 @@ struct onewire_slave_s
* Public Function Prototypes
****************************************************************************/
-/* Additional CRC helpers from 1wire_crc.c */
-
-bool onewire_valid_rom(uint64_t rom);
-
/* Rest are from 1wire.c */
int onewire_addslave(FAR struct onewire_master_s *master,
diff --git a/include/nuttx/1wire/1wire_crc.h b/include/nuttx/1wire/1wire_crc.h
index 7922c5792b4..1dbd00fc8e2 100644
--- a/include/nuttx/1wire/1wire_crc.h
+++ b/include/nuttx/1wire/1wire_crc.h
@@ -82,6 +82,22 @@ uint8_t onewire_crc8(FAR const uint8_t *input, uint8_t len);
uint16_t onewire_crc16(FAR const uint8_t *input, uint16_t len,
uint16_t initial_crc);
+/****************************************************************************
+ * Name: onewire_valid_rom
+ *
+ * Description:
+ * Check CRC-8 of received input
+ *
+ * Input Parameters:
+ * rom - 64-bit rom code
+ *
+ * Returned Value:
+ * true if CRC-8 of rom matches
+ *
+ ****************************************************************************/
+
+bool onewire_valid_rom(uint64_t rom);
+
/****************************************************************************
* Name: onewire_check_crc16
*
