speccy88 commented on code in PR #3567:
URL: https://github.com/apache/nuttx-apps/pull/3567#discussion_r3498314021
##########
interpreters/berry/Makefile:
##########
@@ -71,6 +73,7 @@ $(BERRY_UNPACK): $(BERRY_ARCHIVE)
$(Q) unzip -q -o $(BERRY_ARCHIVE)
$(call DELDIR, $(BERRY_UNPACK))
$(Q) mv berry-$(BERRY_COMMIT_ID) $(BERRY_UNPACK)
+ $(Q) python3 $(BERRY_FIX_CRLF) $(BERRY_MAIN)
Review Comment:
Done. I regenerated the local Berry patch against the pinned upstream CRLF
`default/berry.c` and removed the normalization helper, so both Make and CMake
fetch paths now apply the patch directly to the downloaded archive.
I verified direct patch application against a fresh Berry archive,
`sim:berry` with the Make build, the simulator Berry banner/smoke test, the
CMake testbuild path, `git diff --check`, `cmake-format --check`, and
`checkpatch.sh`.
Once berry-lang/berry#539 is merged, I can open the follow-up PR to update
the pinned Berry commit and drop this local patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
