xiaoxiang781216 commented on code in PR #19236:
URL: https://github.com/apache/nuttx/pull/19236#discussion_r3503286695
##########
Documentation/platforms/arm/rtl8720f/boards/rtl8720f_evb/index.rst:
##########
@@ -114,6 +114,12 @@ See the `Realtek Ameba ImageTool guide
Windows GUI tool and download-mode entry (hold the download button /
power-cycle with the ``UART_LOG_TX`` line asserted).
+**Serial console** — after flashing, connect to the LOG-UART at 1500000 8N1::
Review Comment:
merge into documentation patch
##########
boards/arm/rtl8720f/rtl8720f_evb/configs/nsh/defconfig:
##########
@@ -17,6 +17,7 @@ CONFIG_ARMV8M_SYSTICK=y
CONFIG_BUILTIN=y
CONFIG_DEBUG_ASSERTIONS=y
CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_FULLOPT=y
Review Comment:
merge to board patch
##########
boards/arm/rtl8720f/rtl8720f_evb/scripts/Make.defs:
##########
@@ -26,3 +26,8 @@
# own paths (prebuilt/ staging) derive from $(BOARD_DIR) inside it.
include $(TOPDIR)/arch/arm/src/rtl8720f/ameba_board.mk
+
+# Flashing via the SDK AmebaFlash.py (make flash AMEBA_PORT=/dev/ttyUSB0)
Review Comment:
merge to board patch
##########
arch/arm/src/common/ameba/ameba_wlan.c:
##########
@@ -34,7 +34,7 @@
* TX: ameba_wlan_txpoll -> ameba_wifi_txframe() [ameba_wifi_depend.c]
* RX: netif_adapter_wifi_recv_whc() -> ameba_wlan_rxframe() (this file)
*
- * Modeled on arch/arm/src/rtl8720c/amebaz_netdev.c and the bcmf driver.
+ * Follows the standard NuttX Ethernet-style netdev (devif) RX/TX idiom.
Review Comment:
merge to the chip patch
##########
Documentation/platforms/arm/rtl8720f/boards/rtl8720f_evb/index.rst:
##########
@@ -92,7 +92,27 @@ Realtek ``arm-none-eabi`` toolchain must be on ``PATH``; see
the
$ make
This produces ``nuttx/app.bin`` (the NuttX KM4TZ image2), ``boot.bin`` and the
-NP (KM4NS) image, ready to flash with the Realtek tooling.
+NP (KM4NS) image in the build directory.
Review Comment:
merge to the documentation patch
##########
arch/arm/src/common/ameba/tools/ameba_build_np.sh:
##########
@@ -58,18 +58,20 @@ if [ -n "$AP_ASM" ]; then
export AMEBA_AP_ASM
fi
-# Prefer the SDK venv python (ameba.py tooling); fall back to system python3.
-VENV_PY="$SDK/.venv/bin/python"
+# Use the python dir ameba_setup_env.sh resolved (a real .venv when one
Review Comment:
merge into chip patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
