Zepp-Hanzj commented on code in PR #3585: URL: https://github.com/apache/nuttx-apps/pull/3585#discussion_r3524476589
########## audioutils/lame/Makefile: ########## @@ -102,6 +102,10 @@ ifneq ($(PREFIX),) endif distclean:: - $(Q)cd $(DST_PATH) && make distclean +ifeq ($(DST_PATH),lame) Review Comment: You're right, the `ifeq` guard is unnecessary. Removed it. The `-` prefix in Directory.mk already handles the case where `cd $(DST_PATH)` fails (e.g., lame source not downloaded), so the guard was redundant. ########## Directory.mk: ########## @@ -31,8 +31,9 @@ CLEANSUBDIRS += $(dir $(wildcard */.depend)) CLEANSUBDIRS += $(dir $(wildcard */.kconfig)) CLEANSUBDIRS := $(sort $(CLEANSUBDIRS)) ifeq ($(CONFIG_WINDOWS_NATIVE),y) - CONFIGSUBDIRS := $(subst /,\,$(CONFIGSUBDIRS)) - CLEANSUBDIRS := $(subst /,\,$(CLEANSUBDIRS)) + CONFIGSUBDIRS := $(subst /,\\,$(CONFIGSUBDIRS)) + CLEANSUBDIRS := $(subst /,\\,$(CLEANSUBDIRS)) Review Comment: Done. Removed CLEANSUBDIRS entirely — both `clean` and `distclean` now use SUBDIRS. `make clean` on un-built directories is a harmless no-op, so there's no need to track which directories have markers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
