linguini1 commented on PR #3526: URL: https://github.com/apache/nuttx-apps/pull/3526#issuecomment-4908226049
> For this PR, I was trying to keep the scope limited to replacing the Python dependency in the existing example-local fixture path. But that doesn't make sense, because this PR is what added the Python dependency? So there was nothing to remove, just a change in your implementation of the patch. > I agree the better long-term direction is a shared build helper for nxpkg-compatible fixture generation, instead of per-example host tools. I can keep this PR scoped as-is and we can follow up with that cleanup separately. I think it would be better to start your feature correctly to make it easier for you to package more applications later, but if it's easier then it's okay to put this one in using C-based host tools. Also another thing for later would be to included a SHA hash library instead of rolling your own. But I think it's fine for this PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
