acassis commented on PR #3618:
URL: https://github.com/apache/nuttx-apps/pull/3618#issuecomment-4914963257
Nice work @dmihai03
Please check these issues:
```
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:53:78:
error: Long line found
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:154:78:
error: Long line found
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:274:2:
error: C++ style comment
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:276:2:
error: C++ style comment
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:276:25:
error: Space follows left parenthesis
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:276:43:
error: Space precedes right parenthesis
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:281:3:
error: Right brace must be followed by a blank line
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:415:1:
error: Blank line contains whitespace
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:616:78:
error: Long line found
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:667:7:
error: Mixed case identifier found
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:684:78:
error: Long line found
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:698:1:
error: Blank line contains whitespace
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:725:26:
error: Operator/assignment must be preceded with whitespace
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:734:7:
error: Mixed case identifier found
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:817:1:
error: Missing blank line after comment
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:818:2:
error: Missing whitespace after keyword
Error:
/home/runner/work/nuttx-apps/nuttx-apps/apps/examples/mqttc/mqttc_sub.c:820:1:
error: Missing blank line after comment
```
I noticed there was already a Mixed case identifier in the original code,
please add MQTTErrors to g_white_prefix at nuttx/tools/nxstyle.c to fix this
Mixed case error.
Some suggestion to improve to original code too: move the certificate string
to a separated cert.inc and just add `#include "cert.inc"` to keep it separated
from the source code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
