acassis commented on issue #13884:
URL: https://github.com/apache/nuttx/issues/13884#issuecomment-4939311137

   @raiden00pl I faced this same issue today, even with FS_PROC enabled the 
free still not available, I think the root cause is an inverted logic error 
here:
   
   ```
   /* nsh_catfile used by cat, ifconfig, ifup/down, df, free, env, irqinfo, and
    * mount (with no arguments).
    */
   
   #if !defined(CONFIG_NSH_DISABLE_CAT) && 
!defined(CONFIG_NSH_DISABLE_IFCONFIG) && \
       !defined(CONFIG_NSH_DISABLE_IFUPDOWN) && !defined(CONFIG_NSH_DISABLE_DF) 
&& \
       !defined(CONFIG_NSH_DISABLE_FREE) && !defined(CONFIG_NSH_DISABLE_ENV) && 
\
       !defined(HAVE_IRQINFO) && !defined(HAVE_MOUNT_LIST)
   #  undef NSH_HAVE_CATFILE
   #endif
   ```
   
   Seems like this inverted logic is incorrect. !A && !B => A || B, in case 
even if CONFIG_NSH_DISABLE_CAT is not disabled, it will be undefine 
NSH_HAVE_CATFILE  if any of other NSH_DISABLED_xxx is defined.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to