ricardgb commented on PR #19400: URL: https://github.com/apache/nuttx/pull/19400#issuecomment-4947513048
Thanks for the review @xiaoxiang781216 — all four points addressed in d2531b2: - dropped the local `MIN` fallback and used the `sys/param.h` macro directly (added the include) - `n = MIN(len - got, RP23XX_TRNG_EHR_BYTES);` and `return got;` casts removed as suggested - `sample[][]` in the startup health check is no longer `static` (192 bytes on the stack) Also fixed the `check` CI failures from the previous push (nxstyle long lines and codespell hits on "EHR"); `tools/checkpatch.sh -c -u -m -g` now passes locally on the commit. *(As before: this change was made with the help of an AI agent and human-reviewed before pushing.)* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
