xiaoxiang781216 commented on code in PR #19412:
URL: https://github.com/apache/nuttx/pull/19412#discussion_r3566355275
##########
libs/libc/builtin/Kconfig:
##########
@@ -13,3 +13,15 @@ config BUILTIN
those names in a file system from which they can be executed.
This feature
is also the underlying requirement to support built-in
applications in the
NuttShell (NSH).
+
+config APP_REGISTRY
+ bool
+ default y if BUILTIN || BUILD_KERNEL
Review Comment:
the more natural approach is attached the config as elf symbol, so elf
binfmt could initialize them during loading.
##########
libs/libc/builtin/Make.defs:
##########
@@ -20,7 +20,7 @@
#
############################################################################
-ifeq ($(CONFIG_BUILTIN),y)
+ifneq ($(CONFIG_APP_REGISTRY),)
Review Comment:
need update cmake too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
