xiaoxiang781216 commented on code in PR #19428:
URL: https://github.com/apache/nuttx/pull/19428#discussion_r3575491489
##########
crypto/aes.c:
##########
@@ -855,7 +855,7 @@ int aes_setkey(FAR AES_CTX *ctx, FAR const uint8_t *key,
int len)
return 0;
}
-void aes_encrypt_ecb(FAR AES_CTX *ctx, FAR const uint8_t *src,
+void nx_aes_encrypt_ecb(FAR AES_CTX *ctx, FAR const uint8_t *src,
FAR uint8_t *dst, size_t num_blocks)
Review Comment:
```suggestion
FAR uint8_t *dst, size_t num_blocks)
```
##########
crypto/aes.c:
##########
@@ -905,7 +905,7 @@ void aes_encrypt_ecb(FAR AES_CTX *ctx, FAR const uint8_t
*src,
}
}
-void aes_decrypt_ecb(FAR AES_CTX *ctx, FAR const uint8_t *src,
+void nx_aes_decrypt_ecb(FAR AES_CTX *ctx, FAR const uint8_t *src,
FAR uint8_t *dst, size_t num_blocks)
Review Comment:
```suggestion
FAR uint8_t *dst, size_t num_blocks)
```
##########
crypto/aes.c:
##########
@@ -955,17 +955,20 @@ void aes_decrypt_ecb(FAR AES_CTX *ctx, FAR const uint8_t
*src,
}
}
-void aes_encrypt(FAR AES_CTX *ctx, FAR const uint8_t *src, FAR uint8_t *dst)
+void nx_aes_encrypt(FAR AES_CTX *ctx, FAR const uint8_t *src,
Review Comment:
but do you need add nx_ to all software crypto function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
