FelipeMdeO commented on PR #19209:
URL: https://github.com/apache/nuttx/pull/19209#issuecomment-4997985639

   Hello @Abhishekmishra2808 .
   
   Please revert commit a4c807adcb (your last commit), the base64/ecc collision 
it worked around is already handled by the symbol renaming in 
netutils/dropbear/Makefile, so the strip is redundant. When restoring the 
lines, also add CONFIG_CRYPTO_CRYPTODEV_SOFTWARE_CRYPTO=y (+ 
CONFIG_CRYPTO_SW_AES=y), or /dev/crypto won't have the swcr_pbkdf2 backend and 
PBKDF2 login fails at runtime.
   
   Look for git diff from you last commit:
   ```
   diff --git a/boards/sim/sim/sim/configs/dropbear/defconfig 
b/boards/sim/sim/sim/configs/dropbear/defconfig
   index e5990f622c..3905398c47 100644
   --- a/boards/sim/sim/sim/configs/dropbear/defconfig
   +++ b/boards/sim/sim/sim/configs/dropbear/defconfig
   @@ -16,7 +16,13 @@ CONFIG_ARCH_SIM=y
    CONFIG_BOARD_LOOPSPERMSEC=0
    CONFIG_BOOT_RUNFROMEXTSRAM=y
    CONFIG_BUILTIN=y
   +CONFIG_CODECS_BASE64=y
   +CONFIG_CRYPTO=y
   +CONFIG_CRYPTO_CRYPTODEV=y
   +CONFIG_CRYPTO_CRYPTODEV_SOFTWARE_CRYPTO=y
    CONFIG_CRYPTO_MBEDTLS=y
   +CONFIG_CRYPTO_RANDOM_POOL=y
   +CONFIG_CRYPTO_SW_AES=y
    CONFIG_DEBUG_SYMBOLS=y
    CONFIG_DEV_GPIO=y
    CONFIG_DEV_LOOP=y
   @@ -55,6 +61,7 @@ CONFIG_NET=y
    CONFIG_NETDEV_LATEINIT=y
    CONFIG_NETINIT_DRIPADDR=0x0a000101
    CONFIG_NETINIT_IPADDR=0x0a000102
   +CONFIG_NETUTILS_CODECS=y
    CONFIG_NETUTILS_DROPBEAR=y
    CONFIG_NETUTILS_DROPBEAR_HOSTKEY_PATH="/tmp/dropbear_ecdsa_host_key"
    CONFIG_NET_BROADCAST=y
   
   ```
   
   PS: You changed the password policy, right?
   What do you think about explicitly stating that the password does not meet 
the security policies, and perhaps adding some information that makes it easier 
for the user to identify the security policy?
   
   I don't have relevant background on this point, could you give your opinion, 
@acassis , @xiaoxiang781216 , @ThePassionate ?
   
   I took some time to get issue when I tested dropbear after your change, the 
current output for password out of policy is:
   ```
   ./nuttx
   
   dropbear [6:100]
   
   NuttShell (NSH) NuttX-13.0.0
   nsh> [6] Jun 01 00:00:00 using NuttX passwd auth at /tmp/passwd
   dropbear: listening on port 2222
   
   nsh> useradd test dropbear
   nsh: useradd: passwd_adduser failed: 22
   nsh> 
   
   
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to