patacongo commented on a change in pull request #1728:
URL: https://github.com/apache/incubator-nuttx/pull/1728#discussion_r484461729



##########
File path: boards/arm/sama5/giant-board/src/sam_ethernet.c
##########
@@ -0,0 +1,328 @@
+/****************************************************************************

Review comment:
       This should be removed in its entirety.  The EMAC peripherals are not 
brought out on the Giant Board.  So this file is inappropriate and misleading.
   
   I did add some comments below because I don't think this is the correct 
Ethernet code for the SAMA5D27.  But those comments do not matter... The Giant 
Board does not support Ethernet and the whole file should be removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to