FelipeMdeO commented on code in PR #3648:
URL: https://github.com/apache/nuttx-apps/pull/3648#discussion_r3610647253
##########
netutils/dropbear/Kconfig:
##########
@@ -19,6 +20,7 @@ menuconfig NETUTILS_DROPBEAR
depends on LIBC_GAISTRERROR
select CRYPTO
select CRYPTO_RANDOM_POOL
+ select SCHED_CHILD_STATUS
Review Comment:
Hello @xiaoxiang781216, I'd prefer to keep this as select. With depends on,
whoever writes a defconfig for a new board could forget to enable
SCHED_CHILD_STATUS, and Dropbear would silently be dropped from the build, no
error, it just wouldn't come up. Keeping it as select makes bringing up
Dropbear on a new board simpler and avoids that pitfall.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
