xiaoxiang781216 commented on code in PR #19478: URL: https://github.com/apache/nuttx/pull/19478#discussion_r3610864473
########## drivers/serial/uart_16550.c: ########## @@ -1749,6 +1748,22 @@ void up_putc(int ch) u16550_putc(priv, ch); } + +/**************************************************************************** + * Name: u16550_consoledev + * + * Description: + * Return a pointer to the console uart_dev_t. Used by board logic that + * needs to drive the console RX via polling (e.g. AMP secondary cores + * where the UART RX interrupt cannot be delivered reliably through a GIC + * distributor shared with another OS). + * + ****************************************************************************/ + +FAR uart_dev_t *u16550_consoledev(void) Review Comment: why not disable linux to access it directly? ########## drivers/serial/uart_16550.c: ########## @@ -1749,6 +1748,22 @@ void up_putc(int ch) u16550_putc(priv, ch); } + +/**************************************************************************** + * Name: u16550_consoledev + * + * Description: + * Return a pointer to the console uart_dev_t. Used by board logic that + * needs to drive the console RX via polling (e.g. AMP secondary cores + * where the UART RX interrupt cannot be delivered reliably through a GIC + * distributor shared with another OS). + * + ****************************************************************************/ + +FAR uart_dev_t *u16550_consoledev(void) Review Comment: let's implement the general rx poll directly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
