LingaoM commented on code in PR #19456:
URL: https://github.com/apache/nuttx/pull/19456#discussion_r3627060378


##########
fs/hostfs/hostfs.c:
##########
@@ -616,6 +610,16 @@ static int hostfs_ioctl(FAR struct file *filep, int cmd, 
unsigned long arg)
     {
       switch (cmd)
         {
+          case FIOC_GETLK:
+          case FIOC_SETLK:
+          case FIOC_SETLKW:

Review Comment:
     For the non-POSIX hostfs backends such as ARM semihosting, `host_ioctl()` 
already returned `-ENOSYS`, so host-side ioctl forwarding was not supported 
there before this change. This patch therefore keeps those backends unchanged 
and only implements the FIOC lock translation in the POSIX sim backend, where 
hostfs can actually call the host `fcntl()` API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to