emomaxd commented on PR #19501: URL: https://github.com/apache/nuttx/pull/19501#issuecomment-5042956181
These implementations are unconditional stubs and do not inspect request. POSIX describes ENOSYS as indicating that the interface function is not supported at all, whereas NuttX documents ENOTTY for an ioctl() command that is not recognized. Since host_ioctl() is entirely unimplemented on these backends, wouldn’t -ENOSYS be more accurate here? https://nuttx.apache.org/docs/latest/implementation/ioctl.html https://pubs.opengroup.org/onlinepubs/009696899/xrat/xsh_chap02.html https://pubs.opengroup.org/onlinepubs/9699919799.orig/basedefs/errno.h.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
