aviralgarg05 commented on PR #3644:
URL: https://github.com/apache/nuttx-apps/pull/3644#issuecomment-5069152432
Thanks for the detailed review. I went back through the PR and addressed the
main points:
- the description is now focused on the NXDoom changes;
- every rewritten commit has the required sign-off and `Assisted-by` trailer;
- renderer buffers remain static by default, with heap allocation behind the
explicit Kconfig option;
- the Testing section includes a real RGB565 target photograph, startup and
clean SIGTERM-close output, and the malformed-configuration result; and
- I removed the unsupported argv-sentinel change and corrected my earlier
root-cause claim in that thread.
The original exception log was not retained, and the Testing section now says
that plainly. I have replied to each remaining inline point and resolved the
threads after checking the updated diff and evidence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
