casaroli opened a new pull request, #3667:
URL: https://github.com/apache/nuttx-apps/pull/3667
## Summary
Follow up on the review from @xiaoxiang781216 in apache/nuttx#19537.
Application.mk previously encoded PRIORITY = SCHED_PRIORITY_DEFAULT as an
absolute nx_priority symbol with value zero. A zero priority is invalid for a
runnable application task. Do not emit nx_priority for this symbolic default
instead: when the symbol is absent, the ELF loader keeps its scheduler default.
Explicit numeric priorities continue to be emitted and retained in stripped
module ELFs.
## Impact
This is a focused Apps build-system correction for kernel-build module ELFs.
Applications using SCHED_PRIORITY_DEFAULT no longer receive an invalid
priority-zero ELF attribute. Applications with explicit numeric priorities are
unchanged. There is no API, ABI, configuration, documentation, or
hardware-interface change.
Related review: apache/nuttx#19537.
## Testing
Host: workspace environment with GNU Make.
- ./tools/checkpatch.sh -f ../apps/Application.mk (from the companion NuttX
checkout): passed.
- Focused GNU Make expansion test:
default=
numeric=--defsym nx_priority=50
This confirms the default case emits no linker symbol while an explicit
numeric priority is still emitted.
No NuttX ELF-capable hardware target, cross-compiler, or QEMU runtime is
available in this workspace. This PR is therefore a draft pending the required
build and runtime validation on an ELF kernel-build target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
