ppisa commented on PR #3624: URL: https://github.com/apache/nuttx-apps/pull/3624#issuecomment-5085636180
@Acfboy please, squash, merge commits as @xiaoxiang781216 suggests into single commit or some small logical set of incremental commits, there is no use for keeping the new component development history, you ca keep it on some branch of your repository as work progress documentation. So for logical commits series, I can imagine one commit which introduces Microwindows with basic Kconfig then another one which adds some demos, Kconfig options, etc. But the code has to be clean, adhere NutttX style and requirements and build after each incremental commit. As for the decision, which defines should go into `Makefile` and which to `Make.defs`, I think that only these defines which can be used by potential applications directly or through public Microwindows header files should be present in Make.defs, Sofor example, if `SCREEN_PIXTYPE` is made configurable through Kconfig and then used by header files, then it should be defined in `Make.defs`, same i required for additional include locations. On the other hand defines provided only to choose correct behavior during library build i.e. through `Objects.rules` should be enough to define only in related NuttX `Makefile`. But I think that current state is mostly aligned with these requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
