casaroli commented on code in PR #19536: URL: https://github.com/apache/nuttx/pull/19536#discussion_r3653657825
########## boards/arm/rp23xx/pimoroni-pico-2-plus/scripts/Make.defs: ########## @@ -38,6 +38,9 @@ CXXFLAGS := $(ARCHCXXFLAGS) $(ARCHOPTIMIZATION) $(ARCHCPUFLAGS) $(ARCHXXINCLUDES CPPFLAGS := $(ARCHINCLUDES) $(ARCHDEFINES) $(EXTRAFLAGS) AFLAGS := $(CFLAGS) -D__ASSEMBLY__ +MKNXFLAT = mknxflat +LDNXFLAT = ldnxflat Review Comment: I think so, but since this would touch 13 other files, we might want to do this generalization in a separate PR. I just copied the pattern from the other Make.defs into ours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
