ricardgb commented on code in PR #19470:
URL: https://github.com/apache/nuttx/pull/19470#discussion_r3656479806


##########
drivers/usbdev/cdcncm.c:
##########
@@ -918,14 +918,52 @@ static void cdcncm_transmit_work(FAR void *arg)
   int ndpindex;
   int totallen;
 
-  /* Wait until the USB device request for Ethernet frame transmissions
-   * becomes available.
+  /* Serialise this transmit against cdcncm_send() and against any other

Review Comment:
   Fair — trimmed this from ~20 lines to 3 (just the essential why: shared 
wrreq buffer under the recursive netdev_lock, or delay-0 double-submits and 
wedges TX).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to