Zepp-Hanzj commented on code in PR #19514: URL: https://github.com/apache/nuttx/pull/19514#discussion_r3663183328
########## arch/sim/src/sim/sim_rtc.c: ########## Review Comment: Not directly. On SIM, clock_inittime() reads the RTC through the lower half installed by up_rtc_set_lowerhalf(), which is currently called from up_rtc_initialize(). Moving the whole up_rtc_initialize() call after clock_inittime() would leave the RTC lower half unset and initialize CLOCK_REALTIME to zero. Keeping it before clock_inittime() registers /dev/rtc0 too early. This patch therefore keeps the lower-half setup before time synchronization and defers only the RTC character-device registration until up_initialize(). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
