casaroli commented on PR #19567: URL: https://github.com/apache/nuttx/pull/19567#issuecomment-5101126299
Good call — done. The two conditions are mutually exclusive, so `else ifeq` reads better and drops a redundant `endif`: ```make ifeq ($(CONFIG_WINDOWS_CYGWIN),y) CROSSDEV ?= i486-nuttx-elf- else ifeq ($(CONFIG_HOST_MACOS),y) CROSSDEV ?= i686-elf- endif ``` The two comment blocks are merged into one above it. Re-verified after the change: `qemu-i486:nsh` on macOS/arm64 still selects `i686-elf-gcc` and builds to rc 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
