acassis commented on PR #19599: URL: https://github.com/apache/nuttx/pull/19599#issuecomment-5158480937
> @acassis , The growth is not from mount code. Those boards also typically leave `CONFIG_FS_PERMISSION` off, but we still always call the helpers from VFS (open / stat / rename / …). With permission disabled, they are stubs that return OK, yet the call sites + stub functions still land in .text > > We can zero cost when CONFIG_FS_PERMISSION=n, and wrap those call sites in #ifdef CONFIG_FS_PERMISSION so the stubs disappear from the binary, right? Yes, I think removing these stubs when FS_PERMISSION is disabled it the right approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
