xiaoxiang781216 commented on code in PR #3685: URL: https://github.com/apache/nuttx-apps/pull/3685#discussion_r3699735602
########## testing/fs/fdsantest/fdsantest_simple.c: ########## @@ -96,6 +96,7 @@ static void test_case_overflow(void **state) assert_int_equal(open_count, close_count); } +#ifdef CONFIG_ARCH_HAVE_VFORK Review Comment: why not move to https://github.com/apache/nuttx-apps/pull/3673 ########## netutils/libwebsockets/lws_config_private.h: ########## @@ -43,7 +43,10 @@ /* #undef USE_CYASSL */ /* Define to 1 if you have the `fork' function. */ + +#ifdef CONFIG_ARCH_HAVE_FORK Review Comment: why not move to https://github.com/apache/nuttx-apps/pull/3673 ########## interpreters/python/Makefile: ########## @@ -114,6 +114,11 @@ ifeq ($(CONFIG_ARCH_HAVE_FORK),y) else @echo "export ac_cv_func_fork=\"no\"" >> $@ endif +ifneq ($(CONFIG_ARCH_HAVE_VFORK),) Review Comment: why not move to https://github.com/apache/nuttx-apps/pull/3673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
