xiaoxiang781216 commented on PR #19584:
URL: https://github.com/apache/nuttx/pull/19584#issuecomment-5161686991
> DT_NEEDED is dropped entirely. You're right that shared libraries belong
to dlopen rather than to a loader-private dependency walker. A module carrying
a DT_NEEDED entry will be refused with a clear error rather than loaded and
left to fault. That removes fdpic_loaddepends(), the cross-object symbol
search, the multi-object list and the owner-GOT rule — about a quarter of the
loader, and the quarter with the weakest test coverage. It also removes the
only part of the merge that would have changed behaviour for existing ELF and
dlopen users, since DT_NEEDED loading does not exist in the tree today;
include/elf.h:257 is the tag's only occurrence.
>
it's a great feature, let's do in the new pr by dlopen and bind the needed
module during loading.
> r9 becomes the PIC base register for all of PIC, as a separate PR ahead of
this one. That one turned out to be more interesting than expected — details in
the register thread.
>
> I'm opening the loader work as a fresh PR rather than force-pushing here,
so the two implementations can be compared side by side. I'll close this one
once the new one has been looked at.
>
Thanks for reorg this patch series.
> Two questions still open, in the threads below: the PLT shim, and whether
constructors move to the module's context in this series or a follow-up.
it could be done in the new pr after we merge FDPIC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
