xiaoxiang781216 commented on code in PR #19600:
URL: https://github.com/apache/nuttx/pull/19600#discussion_r3701189067
##########
tools/nxflat/thunk_thumb2.c:
##########
@@ -33,13 +33,21 @@
#include "nxflat_thunk.h"
-/* The format strings are file-scope statics inside the .def, so each
+/* The format strings have file scope inside the .def, so each
* architecture gets its own translation unit and the two sets cannot
- * collide. The .def is byte-for-byte the upstream file.
+ * collide. The .def is the upstream file, less one comment typo.
*/
#include "dyncall_skeleton_thumb2.def"
+/****************************************************************************
+ * Private Functions
+ ****************************************************************************/
+
+/* None: this translation unit exists only to give one architecture's
Review Comment:
move to previous patch
##########
tools/Unix.mk:
##########
@@ -286,6 +286,9 @@ tools/cnvwindeps$(HOSTEXEEXT):
tools/mkpasswd$(HOSTEXEEXT):
$(Q) $(MAKE) -C tools -f Makefile.host mkpasswd$(HOSTEXEEXT)
+tools/mknxflat$(HOSTEXEEXT):
Review Comment:
move to the first patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
