Abhishekmishra2808 commented on code in PR #3557:
URL: https://github.com/apache/nuttx-apps/pull/3557#discussion_r3730383687
##########
nshlib/Kconfig:
##########
@@ -1230,32 +1230,30 @@ config NSH_LOGIN
config NSH_CONSOLE_LOGIN
bool "Console Login"
default n
+ depends on FSUTILS_PASSWD
Review Comment:
The intent was to close a gap where `NSH_CONSOLE_LOGIN` could be enabled
without a real password ever being configured (empty/effectively-bypassable
login), similar to the hard-coded password issue I fixed. But you're right that
this also blocks the `NSH_LOGIN_PLATFORM` path, which doesn't need a password
file at all. I think a better fix would be to scope the dependency to depend on
FSUTILS_PASSWD || NSH_LOGIN_PLATFORM (or move the check into the
NSH_LOGIN_PASSWD choice itself) so platform-verification boards aren't forced
to enable it unnecessarily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
