xiaoxiang781216 commented on code in PR #3693: URL: https://github.com/apache/nuttx-apps/pull/3693#discussion_r3733213492
########## examples/fdpicxip/modules/Makefile: ########## @@ -46,10 +46,10 @@ CPU ?= cortex-m3 FDPICDIR = $(NUTTX_DIR)/tools/fdpic MODULE_MK = $(FDPICDIR)/nuttx-fdpic.mk -EMBED = $(FDPICDIR)/fdpic-embed +EMBED = $(FDPICDIR)/fdpic-embed.py Review Comment: we can change LD in Tooldefine.def to the special version if CONFIG_FDPIC is enabled. > What do you suggest? can we include the "custom" binutils in the CI image? we can add the prebuilt tool to Dockfile directly: https://github.com/apache/nuttx/blob/master/tools/ci/docker/linux/Dockerfile if the tool doesn't have the official release binary, we can build from scratch like bloaty: https://github.com/apache/nuttx/blob/master/tools/ci/docker/linux/Dockerfile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
