michallenc commented on code in PR #19731:
URL: https://github.com/apache/nuttx/pull/19731#discussion_r3735543910
##########
fs/fat/fs_fat32dirent.c:
##########
@@ -1163,9 +1163,23 @@ static int fat_path2dirname(FAR const char **path,
/* Get short file name for given path */
char name[DIR_MAXFNAME];
+ char discard;
+
memcpy(name, dirinfo->fd_lfname, DIR_MAXFNAME);
FAR const char *tmp = (FAR const char *)name;
- fat_parsesfname(&tmp, dirinfo, NULL);
+ if (fat_parsesfname(&tmp, dirinfo, &discard) != OK)
Review Comment:
Why add `discard` here? Nor `tmp` nor `discard` is used anywhere.
##########
fs/fat/fs_fat32dirent.c:
##########
@@ -2361,6 +2375,7 @@ static int fat_putlfname(FAR struct fat_mountpt_s *fs,
return ret;
}
+
Review Comment:
Remove empty line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
