raiden00pl commented on code in PR #19736: URL: https://github.com/apache/nuttx/pull/19736#discussion_r3740192912
########## include/nuttx/analog/mcp445x.h: ########## @@ -0,0 +1,70 @@ +/**************************************************************************** + * include/nuttx/analog/mcp445x.h + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __INCLUDE_NUTTX_ANALOG_MCP445X_H +#define __INCLUDE_NUTTX_ANALOG_MCP445X_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/analog/ioctl.h> + +#include <stdint.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/* IOCTL Commands ***********************************************************/ + +/* Cmd: ANIOC_MCP445X_SET_TCON Arg: struct mcp445x_tcon_s *tcon + * Cmd: ANIOC_MCP445X_GET_TCON Arg: struct mcp445x_tcon_s *tcon + */ + +#define ANIOC_MCP445X_SET_TCON _ANIOC(AN_MCP445X_FIRST + 0) +#define ANIOC_MCP445X_GET_TCON _ANIOC(AN_MCP445X_FIRST + 1) Review Comment: no, private commands should be in private header. The number of private command is defined in `analog/ioctl.h` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
