xiaoxiang781216 commented on code in PR #19794:
URL: https://github.com/apache/nuttx/pull/19794#discussion_r3758679344
##########
arch/Kconfig:
##########
@@ -1583,6 +1571,7 @@ config RAM_VSTART
config RAM_SIZE
int "Primary RAM size"
+ default RAM_SIZE_APP_SET if APP_SET_BOOT_MEMORY_CFG
Review Comment:
why do we need init one Kconfig from another similar Kconfig
##########
arch/Kconfig:
##########
@@ -1562,8 +1532,25 @@ endchoice
menu "Boot Memory Configuration"
+config USE_BOOT_MEMORY_CFG
+ bool "Use boot memory configuration when supported"
+ default n
+ ---help---
+ This option allows enforcing the boot memory configuration in
+ linker scripts. Linker scripts can use this option to determine
+ whether they need to apply the boot memory configuration.
+
+config APP_SET_BOOT_MEMORY_CFG
+ bool
+ default n
+ ---help---
+ This option allows an application configuration to specify
+ the boot memory configuration. It is selected by an application
+ that uses it.
+
config RAM_START
hex "Primary RAM start address (physical)"
+ default RAM_START_APP_SET if APP_SET_BOOT_MEMORY_CFG
Review Comment:
where you define RAM_START_APP_SET?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
