ricardgb commented on PR #19785: URL: https://github.com/apache/nuttx/pull/19785#issuecomment-5258189417
> @ricardgb please test it on stm32f103-minimum and stm32f4discovery, otherwise you could be introducing an issue that we only will notice later when some user try to use it. The board I have is different, so I can't test it. However the compilation doesn't throw any errors: stm32f4discovery:nsh (default): builds clean — no regression. stm32f4discovery with CONFIG_LCD + CONFIG_LEDS_APA102 + CONFIG_LEDS_MAX7219 (the exact combo that fails on master with the APA102_BLACK/MAX7219_BLACK collision): builds clean — the fix resolves it. With LCD=y but LCD_APA102 unset, only drivers/leds/apa102.o compiles (the lcd side is now apa102_lcd.c, gated on its own option), so no shadowing. stm32f103-minimum:nsh (default): builds clean — the small-board build isn't broken by the rename. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
