ppisa commented on code in PR #3689:
URL: https://github.com/apache/nuttx-apps/pull/3689#discussion_r3779810130
##########
graphics/microwindows/Make.defs:
##########
@@ -25,8 +25,7 @@ CONFIGURED_APPS += $(APPDIR)/graphics/microwindows
# It allows `microwindows/src/include` import.
-CFLAGS +=
${INCDIR_PREFIX}$(APPDIR)/graphics/microwindows/microwindows/src/include
-CXXFLAGS +=
${INCDIR_PREFIX}$(APPDIR)/graphics/microwindows/microwindows/src/include
+EXPORTED_INCLUDES +=
${INCDIR_PREFIX}$(APPDIR)/graphics/microwindows/microwindows/src/include
Review Comment:
This commit should be probably divided into two, one which introduce the
feature and another which uses it for Microwindows.
##########
Makefile:
##########
@@ -206,6 +206,13 @@ ifneq ($(BUILTIN_REGISTRY),)
done
endif
endif
+ $(Q) for inc in $(EXPORTED_INCLUDES) ; do \
+ inc=$${inc#"$(INCDIR_PREFIX)"}; \
+ if [ -d "$${inc}" ]; then \
+ mkdir -p "${EXPORTDIR}"$(DELIM)include || exit 1; \
+ cp -Rf "$${inc}"$(DELIM). "${EXPORTDIR}"$(DELIM)include
|| exit 1; \
+ fi \
+ done
endif
Review Comment:
I think that this is right srat, but it seems that there needs to be some
more work because
```
CFLAGS += -DMWCONFIG_FILE='"mwconfig.nuttx"'
```
from `apps/graphics/microwindows/Make.defs` is not propagated some CFLAGS or
similar into `nuttx-export/scripts/Make.defs`.
But this correction can go to another pull round by you or us (I would
discuss with @michallenc ).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
