xiaoxiang781216 commented on code in PR #3719: URL: https://github.com/apache/nuttx-apps/pull/3719#discussion_r3789190598
########## system/nxpkg/pkg_repo.c: ########## @@ -49,16 +48,7 @@ * Pre-processor Definitions ****************************************************************************/ -/* Each webclient_perform() read/sink cycle costs a TCP receive plus an - * SD-card write call; at the old 512-byte size, a sub-1MB file like - * nxdoom's ~940KB ELF took ~1900 round trips and, in practice, close - * to two minutes to install - easily read as "stuck" with only a bare - * spinner for feedback. 4KB cuts that to ~230 round trips and lines - * up with typical SD card erase-block granularity, which also reduces - * write amplification. Still small enough to be a safe stack-local - * buffer against the 16KB (CLI) / 16KB (nxstore install worker) task - * stacks that call into this. - */ +/* Balance network throughput against the 16 KiB caller stacks. */ Review Comment: squash into one patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
