xiaoxiang781216 commented on code in PR #3643:
URL: https://github.com/apache/nuttx-apps/pull/3643#discussion_r3793789187
##########
include/system/nxstore_chrome.h:
##########
@@ -20,38 +20,18 @@
*
****************************************************************************/
-/****************************************************************************
- * Included Files
- ****************************************************************************/
-
-#include "action.h"
-#include "property.h"
+#ifndef __APPS_INCLUDE_SYSTEM_NXSTORE_CHROME_H
+#define __APPS_INCLUDE_SYSTEM_NXSTORE_CHROME_H
/****************************************************************************
- * Public Functions
+ * Pre-processor Definitions
****************************************************************************/
-int init_property_set(FAR struct init_poller_s *ctx,
- FAR const char *key, FAR const char *value)
-{
- init_debug("Setprop key:%s value:%s", key, value);
- init_action_trigger_event(ctx->am, key, value);
- return 0;
-}
-
-void init_property_handler(FAR struct init_poller_s *ctx)
-{
- UNUSED(ctx);
-}
+/* Full-screen applications launched by nxstore share the framebuffer with
+ * its supervisor bar. They must leave this top strip untouched so the
+ * Close control remains visible and usable.
+ */
-void init_property_deinit(FAR struct init_poller_s *ctx)
-{
- UNUSED(ctx);
-}
+#define NXSTORE_BAR_HEIGHT 36
Review Comment:
why need expose public header
##########
system/nxstore/nxstore_main.c:
##########
@@ -0,0 +1,1674 @@
+/****************************************************************************
+ * apps/system/nxstore/nxstore_main.c
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <errno.h>
+#include <fcntl.h>
+#include <pthread.h>
+#include <signal.h>
+#include <spawn.h>
+#include <stdarg.h>
+#include <stdatomic.h>
+#include <stdio.h>
+#include <string.h>
+#include <sys/stat.h>
+#include <sys/wait.h>
+#include <syslog.h>
+#include <time.h>
+#include <unistd.h>
+
+#include <lvgl/lvgl.h>
+
+#include <system/nxstore_chrome.h>
+
+#include "../nxpkg/pkg.h"
Review Comment:
should we expose some nxpkg header file publicly
##########
system/nxstore/Kconfig:
##########
@@ -0,0 +1,40 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config SYSTEM_NXSTORE
+ tristate "Nxstore LVGL App Store"
+ default n
+ depends on GRAPHICS_LVGL && SYSTEM_NXPKG && SCHED_WAITPID
+ select NETUTILS_CJSON
Review Comment:
depends on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
