mpflanzer commented on code in PR #19891: URL: https://github.com/apache/nuttx/pull/19891#discussion_r3801624636
########## include/cxx/bits/std_abs.h: ########## @@ -0,0 +1,64 @@ +//*************************************************************************** +// include/cxx/bits/std_abs.h Review Comment: I added them to this separate header to avoid duplicating them across `cmath` and `cstdlib`. According to the standard both of these headers define the float overloads: > The headers [<cstdlib>](https://eel.is/c++draft/cstdlib.syn#header:%3ccstdlib%3e) and [<cmath>](https://eel.is/c++draft/cmath.syn#header:%3ccmath%3e) declare the functions described in this subclause > > [...] > > constexpr floating-point-type abs(floating-point-type x); > https://eel.is/c++draft/c.math.abs#headerref:%3Ccstdlib%3E -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
