[GitHub] [incubator-nuttx-apps] v01d commented on a change in pull request #380: Fix: ensure archive files do not carry object files from prior builds

[GitBox]

v01d commented on a change in pull request #380:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/380#discussion_r487412565



##########
File path: Application.mk
##########
@@ -131,13 +131,12 @@ $(CXXOBJS): %$(SUFFIX)$(OBJEXT): %$(CXXEXT)
        $(if $(and $(CONFIG_BUILD_LOADABLE),$(CXXELFFLAGS)), \
                $(call ELFCOMPILEXX, $<, $@), $(call COMPILEXX, $<, $@))
 
-.built: $(OBJS)
+link:
 ifeq ($(CONFIG_CYGWIN_WINTOOL),y)
-       $(call ARLOCK, "${shell cygpath -w $(BIN)}", $^)
+       $(call ARCHIVE_ADD, "${shell cygpath -w $(BIN)}", $(OBJS))
 else
-       $(call ARLOCK, $(BIN), $^)
+       $(call ARCHIVE_ADD, $(BIN), $(OBJS))
 endif
-       $(Q) touch $@

Review comment:
       Yes, it appears .depend covers it, don't really understand the purpose 
of the extra search for .built.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org