xiaoxiang781216 commented on code in PR #19911:
URL: https://github.com/apache/nuttx/pull/19911#discussion_r3832627017


##########
drivers/video/fb.c:
##########
@@ -1953,6 +2061,7 @@ int fb_register_device(int display, int plane,
     }
 
   DEBUGASSERT((unsigned)plane <= UINT8_MAX);
+  fb->display = display;

Review Comment:
   where display field get real use



##########
arch/arm/src/stm32h7/stm32_ethernet.c:
##########
@@ -1128,6 +1128,17 @@ static struct eth_desc_s *stm32_get_next_txdesc(struct 
stm32_ethmac_s *priv,
  *
  ****************************************************************************/
 
+static bool stm32_txringfull(FAR struct stm32_ethmac_s *priv)

Review Comment:
   could you move the no vnc change to new pr



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to