zhangyu-duck commented on PR #3733: URL: https://github.com/apache/nuttx-apps/pull/3733#issuecomment-5392083834
The checkpatch `Mixed case identifier` errors in `ssl_lib.c` are pre-existing issues from the OpenSSL API (e.g., `SSL_get1_session`, `SSL_ASSERT2`, `SSL_SESSION_free`). These are OpenSSL/mbedtls function names defined by the upstream API and cannot be renamed. This PR only changes `atomic_fetch_add` → `atomic_add` and `atomic_fetch_sub` → `atomic_sub` (2 lines). The entire file is full of these mixed case identifiers, so fixing them would require rewriting the whole file against the OpenSSL API, which is not practical. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
