JianyuWang0623 commented on PR #3751:
URL: https://github.com/apache/nuttx-apps/pull/3751#issuecomment-5407741734
Root cause of the risc-v-03 CI failure identified and fixed upstream,
unrelated to this PR's changes.
**What happened:** `nuttx#19952` (boards: update LVGLTERM requirements) and
`nuttx-apps#3742` (examples/lvglterm: replace PIPES with PSEUDOTERM) were
merged 4 seconds apart:
- `#19952` explicitly added `CONFIG_PSEUDOTERM=y` to three board defconfigs
(`esp32p4-tab5/lvgl_term`, `esp32s3-m5-cardputer/lvglterm`,
`linum-stm32h753bi/lvglterm{,_kbda}`) so lvglterm would build, since at that
point the app still relied on plain pipes.
- `#3742` (merged seconds later) switched lvglterm to run the shell on a
pseudo-terminal instead of pipes, and made `EXAMPLES_LVGLTERM` do `select
PSEUDOTERM`, making the explicit line redundant. It also left `CONFIG_PIPES=y`
as dead weight in those same defconfigs from the old pipe-based implementation.
Neither PR's author was aware of the other at merge time, so the redundant
lines were never cleaned up. `testbuild.sh` runs `refresh.sh` (savedefconfig
normalization) and diffs it against the committed defconfig — since both lines
are now implied rather than needed, the diff comes back non-empty and the
tree-cleanliness check fails. This PR's CI run happened to land on a nuttx SHA
right after `#19952` merged, so it caught the window.
**Fix:** opened https://github.com/apache/nuttx/pull/19963 to drop the two
now-redundant options from all four affected defconfigs. Verified `refresh.sh
--silent` now reports a clean diff and all four configs (esp32p4-tab5,
esp32s3-m5-cardputer, linum-stm32h753bi x2) still build successfully across
their respective toolchains, plus `checkpatch.sh` passes on all four files.
This is unrelated to `system/nxinit` and doesn't block this PR's merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
