v01d commented on pull request #1125:
URL: https://github.com/apache/incubator-nuttx/pull/1125#issuecomment-691534462


   @liuguo09 can you explain this PR again? I found this while looking for 
something else and from the changes it would appear that a mkdep call could 
fail and this would ignore the failure, since `exit` with no parameters does 
not generate a non-zero exit status. I believe this should be `false` not `exit`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to