JianyuWang0623 commented on PR #19984: URL: https://github.com/apache/nuttx/pull/19984#issuecomment-5437899852
Thanks for the review. You're right — the `=8192` overrides weren't justified, and the branch also carried a stray `CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE=2048` that `savedefconfig` had pulled in. I've reworked the whole series to a minimal delta: - Dropped `CONFIG_INIT_STACKSIZE=8192` and `CONFIG_SYSTEM_NSH_STACKSIZE=8192` everywhere — they now keep their Kconfig default (`DEFAULT_TASK_STACKSIZE`). - Removed the spurious `TELNETD_SESSION_STACKSIZE` and any other non-essential line the tooling had introduced. Each defconfig now changes only the nxinit-essential keys, e.g. `adb`: ``` -CONFIG_INIT_ENTRYPOINT="nsh_main" +CONFIG_INIT_ENTRYPOINT="init_main" +CONFIG_EXPERIMENTAL=y # only where not already set +CONFIG_SYSTEM_NXINIT=y ``` (plus `LIBC_EXECFUNCS` / `SCHED_CHILD_STATUS` / `SCHED_HAVE_PARENT` / `ETC_ROMFS` / `FS_ROMFS` only on the configs that didn't already have them). The only non-`INIT_ENTRYPOINT` removal is dropping `CONFIG_BINFMT_DISABLE=y` on 5 sim configs (dynconns, module, module32, sotest, sotest32), because `SYSTEM_NXINIT` needs `LIBC_EXECFUNCS` which depends on `!BINFMT_DISABLE` (nxinit spawns services via `exec()`). Force-pushed; the 3 per-board commits are updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
