Kaben123 commented on PR #19991: URL: https://github.com/apache/nuttx/pull/19991#issuecomment-5453706916
> @Kaben123 please verify why this PR is increasing from +124 to +672 in some boards Thanks @acassis. The variance comes from per-board Kconfig, not from bloat in the patch: s698pm-dkit/nsh enables CONFIG_DEBUG_ASSERTIONS=y + CONFIG_DEBUG_FEATURES=y; stm32-nucleo-f103rb/nsh enables neither. The touched functions (_inode_search, _inode_checkpath, _inode_canonicalize, rename, link) contain several DEBUGASSERT()s — each expands to a call + panic string on s698pm and to nothing on f103rb. s698pm also lacks CONFIG_DEBUG_FULLOPT=y (→ -O0) while f103rb has it (→ -Os), and SPARC is fixed 4-byte insns vs Thumb-2's ~2-byte average. Compounded: 1.2 × 2.5 × 1.7 ≈ 5×, matching 672 / 124 ≈ 5.4×. MemBrowse per-symbol data confirms the growth is confined to the functions this PR touches (e.g. qemu-armv8a: .text.inode_search +256, .text.rename +84) — no unexpected symbols, no duplicated inlining. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
