Fishwaldo commented on code in PR #19861: URL: https://github.com/apache/nuttx/pull/19861#discussion_r3885964570
########## drivers/usbhost/usbhost_xhci.c: ########## @@ -160,6 +160,16 @@ struct xhci_epinfo_s size_t dmacopy; /* Length to copy back out of a stand-in */ bool dmain; /* Direction this buffer was prepared for */ sem_t iocsem; /* Semaphore used to wait for transfer completion */ + + /* One transfer at a time on an endpoint. The controller lock below is Review Comment: Technically it can, but it's a much larger refactor across the XHCI driver already. We don't currently map completion ID's to endpoints that is needed to track multiple submissions. I'd suggest that work comes as a different PR later? It's pretty invasive (and this PR is already complex as it is!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
