casaroli commented on code in PR #19942:
URL: https://github.com/apache/nuttx/pull/19942#discussion_r3897790188
##########
libs/libc/elf/elf_load.c:
##########
@@ -364,6 +365,13 @@ static inline int libelf_loadfile(FAR struct
mod_loadinfo_s *loadinfo)
{
if (phdr->p_flags & PF_X)
{
+ if (loadinfo->fdpic && loadinfo->xipbase != 0)
Review Comment:
I think we still need the fdpic test. that block is inside
`if (e_type == ET_DYN)`, and `xipbase` also gets set by the plain
`FIOC_XIPBASE` path for any object on an xip filesystem. so without it we
would
skip copying the text of a non-fdpic ET_DYN that was never placed for xip.
or did you mean something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
